From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail-a.sr.ht; dkim=pass header.d=johnnyrichard.com header.i=@johnnyrichard.com Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) by mail-a.sr.ht (Postfix) with ESMTPS id E5893200C3 for <~johnnyrichard/olang-devel@lists.sr.ht>; Fri, 16 Feb 2024 07:14:53 +0000 (UTC) Date: Fri, 16 Feb 2024 09:17:02 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=johnnyrichard.com; s=key1; t=1708067693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=melnFsehPQt81Zrywdlz7+aXJPzmE3DhU5+9ol+AOxA=; b=wQzGINvv8F7tqYCPdoEA6v7jS4zt3gs8DjBEajn7SoHjcpQ0FyxXqI8G/8i8du3ECNNEar LF+MMsXgnAVEapQ3qAiZF+rWdZkPrUnIOEI9tgqLZSiMZdSC80jBXU3mcv77VwIcXHFhVC +3CbuDEQtZcAfeYOgJzk5A+cQb5Wk307pktuS+s9sObCgqeO9voiFZ6B304W94mYtwrqru mIOCard2Ilfl8oc73xlz7Xn4hz9AlgpeWBclFBHK6/uzhI8ecjQpMt/ab8JXJXw0bVJ7a9 PcdlBDYlXD2HS7df3yM7PL+9tPWmr/4RCBYo97SbUX7iMkoSqu02y1k/NuxHVA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Johnny Richard To: Carlos Maniero Cc: ~johnnyrichard/olang-devel@lists.sr.ht Subject: Re: [PATCH olang 2/2] tests: add integration test setup Message-ID: <2tf46gbtznj63ffzokimrpzvq3lyiqekwehvtd5yb67u4lunyy@u7h6lun7iiuf> References: <20240215162146.847336-1-carlos@maniero.me> <20240215162146.847336-3-carlos@maniero.me> <2fltgo6fnzgcnrmvi5akr7d5kc7qkrfsxaketlsdet4my5i6c2@hfozssfoes3o> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-TUID: ojqk7+650oJ8 Thanks for the reply. On Thu, Feb 15, 2024 at 11:27:00PM -0300, Carlos Maniero wrote: > > What is the motivation behind segregate integration tests from unit > > tests? > > I might be dreaming at this point, but I know you kinda share the same > dream of making olang a self-hosted language. With this in mind, I think > it is a good idea to have these two levels of testing: unit tests will > test c-related stuff and implementation details, while integration tests > will test the compiler features by calling the compiler with a > *system()* call. > > When we start to rewrite the compiler in olang, the unit tests may > change because we gonna change the design of the compiler to remove the > "c-accent". On the other hand, integration tests should not be touched > during the rewriting process because the features will stay the same. Yeah, we do share the same dream :), but maybe is too early to optimize it. In the end, everything is a binary, and we are using Makefile to run the tests, I cannot see any problem on having two different languages within test folder. Anyhow we can keep it like this. I don't have a strong opinion to be honest. > > What is binary_loc? Does it means location or path? > > Yeah! that name sucks. It is the compilation result binary path. > WDYT about rename it to *program_path*? I think /loc/ also works. I was trying to confirm if I understood correctly. But sure, /program_path/ is clearer. > And sorry about the previous empty email, I've no idea what happened. No worries.