From: Johnny Richard <johnny@johnnyrichard.com>
To: Carlos Maniero <carlos@maniero.me>
Cc: ~johnnyrichard/olang-devel@lists.sr.ht
Subject: Re: [PATCH olang 2/2] utils: create hash map data structure
Date: Tue, 27 Feb 2024 21:05:26 +0100 [thread overview]
Message-ID: <5yxldvexvaxny663xoecnn3p6bmfcuu35jwpxpssingltx2o2a@rf76hxsy36zy> (raw)
In-Reply-To: <CZG311Z668RN.1IQM621M5S8HU@maniero.me>
On Tue, Feb 27, 2024 at 03:44:56PM -0300, Carlos Maniero wrote:
> Fixing the suggestions based on Johnny's comments:
>
> - on map_test I was asserting after freeing the memory
> - on map.c there was a bug where I was valdating that the entry was NULL
> not the entry->key which was leading to always having an empty first
> entry (not a SEGFAULT).
> - It does not makes sense to have strdup on arena.
> - Instead I just kept the convention to have a single _.
>
> If you think we are good to go, please send a v2. So it will trigger the
> pipeline.
I applied you change to a version 2, I have not comments, this fixup
looks good.
Thanks for the scissor patch.
next prev parent reply other threads:[~2024-02-27 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 22:20 [PATCH olang 0/2] introduce " Johnny Richard
2024-02-21 22:20 ` [PATCH olang 1/2] build: add clean target on root Makefile Johnny Richard
2024-02-21 22:20 ` [PATCH olang 2/2] utils: create hash map data structure Johnny Richard
2024-02-21 21:24 ` [olang/patches/.build.yml] build success builds.sr.ht
2024-02-27 17:26 ` [PATCH olang 2/2] utils: create hash map data structure Carlos Maniero
2024-02-27 19:30 ` Johnny Richard
2024-02-27 18:44 ` Carlos Maniero
2024-02-27 20:05 ` Johnny Richard [this message]
2024-02-27 20:03 ` Johnny Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5yxldvexvaxny663xoecnn3p6bmfcuu35jwpxpssingltx2o2a@rf76hxsy36zy \
--to=johnny@johnnyrichard.com \
--cc=carlos@maniero.me \
--cc=~johnnyrichard/olang-devel@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.johnnyrichard.com/olang.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox