From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mail-a.sr.ht; dkim=pass header.d=johnnyrichard.com header.i=@johnnyrichard.com
Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [IPv6:2001:41d0:203:375::ab])
	by mail-a.sr.ht (Postfix) with ESMTPS id ECB2520172
	for <~johnnyrichard/olang-devel@lists.sr.ht>; Tue, 27 Feb 2024 19:05:28 +0000 (UTC)
Date: Tue, 27 Feb 2024 21:05:26 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=johnnyrichard.com;
	s=key1; t=1709060728;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=BIHGHK+LCmWLLv+N9aqxrJXt/uUm9CtYYflAz7TwUZU=;
	b=TbceyPergHxr/DDuzpw/rG44Fgmq/5MQEe1IMJ7J+us/acKwpIQgBeWtA40Q74IrWzdJ0z
	3968hoAVEF6baJk+97/79+uFvsHFDMOO3+vKvNKrqOdcC+B2R0I6kUNcMKcz+ctpK/Fc0B
	mjHSlW9gRRBskaklSptMRWW3pbtHcNhSDPztQsOegos8vP/iSb1IgsCbhexCH5c+c501aC
	HKJ1apQCR94rffG4wpZWKQdLgsNs/Ip3796F/j/hbJpmm/Wc8xpPAfuRjdhXCqacDkjHEE
	X5LTK8McRl1mEXbP3+fuKy+TtphuGyONK8QxWB0AQZAqUZMAtbdNMmQIsYKrug==
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Johnny Richard <johnny@johnnyrichard.com>
To: Carlos Maniero <carlos@maniero.me>
Cc: ~johnnyrichard/olang-devel@lists.sr.ht
Subject: Re: [PATCH olang 2/2] utils: create hash map data structure
Message-ID: <5yxldvexvaxny663xoecnn3p6bmfcuu35jwpxpssingltx2o2a@rf76hxsy36zy>
References: <20240221222226.67254-1-johnny@johnnyrichard.com>
 <20240221222226.67254-3-johnny@johnnyrichard.com>
 <CZG311Z668RN.1IQM621M5S8HU@maniero.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CZG311Z668RN.1IQM621M5S8HU@maniero.me>
X-Migadu-Flow: FLOW_OUT
X-TUID: cjW/Dly2wwxe

On Tue, Feb 27, 2024 at 03:44:56PM -0300, Carlos Maniero wrote:
> Fixing the suggestions based on Johnny's comments:
> 
> - on map_test I was asserting after freeing the memory
> - on map.c there was a bug where I was valdating that the entry was NULL
>   not the entry->key which was leading to always having an empty first
>   entry (not a SEGFAULT).
> - It does not makes sense to have strdup on arena.
>   - Instead I just kept the convention to have a single _.
> 
> If you think we are good to go, please send a v2. So it will trigger the
> pipeline.

I applied you change to a version 2, I have not comments, this fixup
looks good.

Thanks for the scissor patch.