Re: [PATCH olang v1 2/4] string_view: add string view conversion to uint32_t

[Johnny Richard <johnny@johnnyrichard.com>]

On Thu, Feb 29, 2024 at 12:16:07PM -0300, Carlos Maniero wrote:
> > +    memset(ret, 0, str.size + 1);
> > +    memcpy(ret, str.chars, str.size);
> This will iterate *str.size* times twice. Instead of using *memset* you
> could only set the *NULL terminator* as the last char of *ret*.

Sure, I will fix it in an other revision.

> > +static MunitResult
> > +string_view_eq_to_cstr_test(const MunitParameter params[], void *user_data_or_fixture)
> > +{
> > +    char *name = "John Doe";
> > +
> > +    string_view_t str = { .chars = name, .size = strlen(name) };
> > +
> > +    assert_true(string_view_eq_to_cstr(str, "John Doe"));
> > +    assert_false(string_view_eq_to_cstr(str, "Doe"));
> > +
> > +    return MUNIT_OK;
> > +}
> It would be great if you add also a test taking just a portion of the
> string to make sure the *.size* is working.

Hmm... I think it's better to create a separated test for this.

> > +static MunitResult
> > +string_view_to_u32_test(const MunitParameter params[], void *user_data_or_fixture)
> > +{
> > +    char *number = "69";
> > +
> > +    string_view_t str = { .chars = number, .size = strlen(number) };
> > +
> > +    assert_uint32(string_view_to_u32(str), ==, 69);
> > +
> > +    return MUNIT_OK;
> > +}
> Same here. Instead of taking the entire number you can get just a digit.

I will create another test for this.  Something like test create slice over cstr.