From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail-a.sr.ht; dkim=pass header.d=maniero.me header.i=@maniero.me Received: from silver.cherry.relay.mailchannels.net (silver.cherry.relay.mailchannels.net [23.83.223.166]) by mail-a.sr.ht (Postfix) with ESMTPS id 7D93F200EC for <~johnnyrichard/olang-devel@lists.sr.ht>; Fri, 16 Feb 2024 02:27:11 +0000 (UTC) X-Sender-Id: hostingeremail|x-authuser|carlos@maniero.me Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 933C310072D for <~johnnyrichard/olang-devel@lists.sr.ht>; Fri, 16 Feb 2024 02:27:09 +0000 (UTC) Received: from fr-int-smtpout5.hostinger.io (unknown [127.0.0.6]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id B11321016F7 for <~johnnyrichard/olang-devel@lists.sr.ht>; Fri, 16 Feb 2024 02:27:08 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1708050429; a=rsa-sha256; cv=none; b=a5g85P9YhNd+4QIujLyfcPjFBkbQeQkMnJznQ4mS6YdS8prQk+15LgGwqgWaJ8w/SrHQ26 f5M97HxZBKENeyw/6FaBHvHnDeFnwuziXTtkjLzDQbGfU/yhHsyZxdb/xoE0imP/T2XnxB T6zllrf1U3yT0bCTB13sSw4A4TUS9zadxI4A/F49oPxTgPMc71+2EORbNN+XAd17+r6sP8 JrlDJCezOqCyYZKILs3YWWLfmwla+C0hOgZcJYauYCLkHtudT6YmXM1LVfaZ4P9ruGyyOA JPBON29ING0iB7Zv4XVLrJ0DALGWWcB+dzwatIUmMvirfaKZRISQGqZGB7GVSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1708050429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B5FEEf6mrLqf7O8Ne4v8fDErAifia/3Wq3K9EV2xq60=; b=4unaEzCUrZK6KPORJCsxVK6gpcNTXx5Q5WahL+9sVhXiLW0pmkbbKSDrr3rkNAO48ofkbX EFkS3Ao6FSeveNhUR+KlG4LWa8dmraeudPM+hXuDbpWfx8bYmB3AiaTZ35lQOjifSaj+qY wfgJINt31Tmby5ISBc8LBCur+xdqoBKf5QcM6QPhihAnUawqKVKysUlyzXwtHHsuKSuFBx jbfmx1Rg9UzfGA5cvgQvhXf9AWXqik43d+d63ATZKJOHj37WoPSG/Odfp1CaM8InR10eOw a9t2P/lqCS0XefRiC7yynUhljUB/cgI3ag0p0ThCq9A1QjPq37h1zVFbvrDrIw== ARC-Authentication-Results: i=1; rspamd-55b4bfd7cb-v5lrx; auth=pass smtp.auth=hostingeremail smtp.mailfrom=carlos@maniero.me X-Sender-Id: hostingeremail|x-authuser|carlos@maniero.me X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|carlos@maniero.me X-MailChannels-Auth-Id: hostingeremail X-Abortive-Chemical: 7e92820d554df3b3_1708050429233_2390534426 X-MC-Loop-Signature: 1708050429233:3944698540 X-MC-Ingress-Time: 1708050429233 Received: from fr-int-smtpout5.hostinger.io ([UNAVAILABLE]. [89.116.146.168]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.115.180.201 (trex/6.9.2); Fri, 16 Feb 2024 02:27:09 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maniero.me; s=hostingermail1; t=1708050426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B5FEEf6mrLqf7O8Ne4v8fDErAifia/3Wq3K9EV2xq60=; b=eWdTbKBdfshpRHjqyp/K9cI1ICF/kSMOQVAJkYSn1+hYehM3swRlo3j349+i+FABLIU8Zm 3TWpPRKULsj1dcz18BjScjvO0Sr1uGo9jfFaL7jljksTREj6BRfseqQoTt60cFaSBSiHBj paaSiLVbyR2mv6y4Pj8xCU/+oBg2HdXnioqkUrd99RHzB//QUBCXOT2xJvJ/91vUJNOhft 76YVqkdtgVdFeSRqwq4CM7e1y2Bi1SnO3C6+Zf8ClSWs/wLDjkjHLzr+pTR39c2sOv2ixT CdGjgVeOfE9R9OeWR5KBT7gvVTpGueq6Bg+mVCbBywa7495sjaIm9DIRFWpHew== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 15 Feb 2024 23:27:00 -0300 Message-Id: Cc: <~johnnyrichard/olang-devel@lists.sr.ht> Subject: Re: [PATCH olang 2/2] tests: add integration test setup From: "Carlos Maniero" To: "Johnny Richard" X-Mailer: aerc 0.15.2-211-g37d5fc691aff References: <20240215162146.847336-1-carlos@maniero.me> <20240215162146.847336-3-carlos@maniero.me> <2fltgo6fnzgcnrmvi5akr7d5kc7qkrfsxaketlsdet4my5i6c2@hfozssfoes3o> In-Reply-To: <2fltgo6fnzgcnrmvi5akr7d5kc7qkrfsxaketlsdet4my5i6c2@hfozssfoes3o> X-CM-Analysis: v=2.4 cv=apu0CzZV c=1 sm=1 tr=0 ts=65cec7fa a=5+VMC1FZ3J4mVPAKpPmAqg==:117 a=5+VMC1FZ3J4mVPAKpPmAqg==:17 a=IkcTkHD0fZMA:10 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=BXDaF_L80NYA:10 a=lL3LRctPsoPgxTXJCd0A:9 a=QEXdDO2ut3YA:10 X-CM-Envelope: MS4xfP05inP6a3OCPp4QdQ3p9JbzR0LKsReZFxoMpDbTr6L1GTUQ3iCHQyW0d21r2qi/9+WFvQEMyOFxe2JV5AazGGkDOSZkG/hCxArIsmDvgDyDpO2aID6N ysZQmwLZmTlQhUnNoQ+o5ccyY6XkPEe0LigNh4bcCceO5Shb+oVer1XQnk2gTqkG70p2EHnSprqVSl8gbIOvF8YmDUfh4hRpqDwE3bismOiSSASaCsoAqypk cM/0AKz6+j+Frjiy9alzUA== X-AuthUser: carlos@maniero.me X-TUID: 6j/wf4QNBk22 Thanks for the feedback, I'll answer some of you questions here. The ones I didn't address here is because I just agree and the fix will be sent on the next patchset. > What is the motivation behind segregate integration tests from unit > tests? I might be dreaming at this point, but I know you kinda share the same dream of making olang a self-hosted language. With this in mind, I think it is a good idea to have these two levels of testing: unit tests will test c-related stuff and implementation details, while integration tests will test the compiler features by calling the compiler with a *system()* call. When we start to rewrite the compiler in olang, the unit tests may change because we gonna change the design of the compiler to remove the "c-accent". On the other hand, integration tests should not be touched during the rewriting process because the features will stay the same. > What do you think about the /linter-fix/ and /linter/ scan all files > instead of introducing new targets with -all suffix? I like to have small targets that are composed this brings more flexibility to my workflow, but I have no strong opinion with this one. I'll change they in the reviewed patchset. > nitpick: I cannot see a big benefit of adding an underscore for this > property neither for methods. I understand you want to communicate that > it should not be access by other sources. >=20 > What do you think about making these "_" properties and functions > static? I love the idea. > What is binary_loc? Does it means location or path? Yeah! that name sucks. It is the compilation result binary path. WDYT about rename it to *program_path*? And sorry about the previous empty email, I've no idea what happened.