From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mail-a.sr.ht; dkim=pass header.d=maniero.me header.i=@maniero.me Received: from slateblue.cherry.relay.mailchannels.net (slateblue.cherry.relay.mailchannels.net [23.83.223.168]) by mail-a.sr.ht (Postfix) with ESMTPS id B762520265 for <~johnnyrichard/olang-devel@lists.sr.ht>; Tue, 27 Feb 2024 23:22:42 +0000 (UTC) X-Sender-Id: hostingeremail|x-authuser|carlos@maniero.me Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 9D0F4362A95 for <~johnnyrichard/olang-devel@lists.sr.ht>; Tue, 27 Feb 2024 23:22:40 +0000 (UTC) Received: from nl-srv-smtpout4.hostinger.io (unknown [127.0.0.6]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id E1EA3362C90 for <~johnnyrichard/olang-devel@lists.sr.ht>; Tue, 27 Feb 2024 23:22:39 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1709076160; a=rsa-sha256; cv=none; b=zXdrVVgSJbbO1JxSVmjJGTSX/sKLVH65kxlY1xnBlUZab1f7jDuJWMwbksNIQdqnlmDCgr 5X0qam38jsKjf+mAAcaqL8R56m1fIhFs8FDFV5WZaycZL9b94rAVZCfotkFXw3zw/LFj23 kqqV97y31pLrSKxfuuVRhViu43EX+nms8MDhcVGqvz8wx8MtLIMz3Wghd2sd7vfNGfYo1T jEOWLpAyW3C9QzAkt5Vrnt6nT9AU6k9syh5NRPzKwB08eTAGfX9GCjAzmF7tc/rnejtIwd 7JZi17Vk/tEuJrZ7bd0YltaTQ2cfE2KNSkHNF5/+kdSHyp78Ck7wWcNr0uwshA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1709076160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c2AmOuLe8MsOt/FpMr2K7Bxe15B/1ZhsfhKyxTMq9TU=; b=e+7IdJBQj1X1MqTV+h4RXd/9J4DOemGiismagPfXPFiujdDS5FpHX55g5mPcboeUPZ+K5H AkwKl12zMyOx1hw3de52SSh3Han+DxnpuqJEyO4HpGKmwtt2cjEdMdD+ppzEHiui4hi6N4 wTLlZgRwhRZWkVbyFLoufulLsfHM8XSNgOxIH+J8ispjFOYPjkYXb1avQPgLvHK7nCbdh+ igQPoVJfzlh5HlxJfBrekCkNzE/LEqx22wvkTLFms+cUlMc3XdYRHI29cMIgDnAfXA+aNA xo0+Fw7USujv6x+cqj2mVpP0FVeYpVrpiciC3JloUSxnkRN16PdwkPuDsmrfJA== ARC-Authentication-Results: i=1; rspamd-55b4bfd7cb-zdc5v; auth=pass smtp.auth=hostingeremail smtp.mailfrom=carlos@maniero.me X-Sender-Id: hostingeremail|x-authuser|carlos@maniero.me X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|carlos@maniero.me X-MailChannels-Auth-Id: hostingeremail X-Daffy-Gusty: 5c3b338e2af82c3f_1709076160397_2342074257 X-MC-Loop-Signature: 1709076160397:2706330536 X-MC-Ingress-Time: 1709076160396 Received: from nl-srv-smtpout4.hostinger.io (nl-srv-smtpout4.hostinger.io [145.14.159.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.116.14.46 (trex/6.9.2); Tue, 27 Feb 2024 23:22:40 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maniero.me; s=hostingermail1; t=1709076158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c2AmOuLe8MsOt/FpMr2K7Bxe15B/1ZhsfhKyxTMq9TU=; b=Co5VkgYLUzv+v5Zv998n7XmbT688nP27lXPcUTzqikFPK071/gaQmhsFpk55f2pJwhtFfJ ZLSBtT/J6nHW1WjGnqaJmelByjfqacZpExTVn6LlOH3wq4TTyjdnwGYs6/S+otovGRbRVU 1ruFjfnzRc1LcsU8MuVYuYwJMdjrpxG/t5VBrpMPd5YbeggG7eeltSfPf2xWNfqoGJZvZH Hinh1YhsXfmx8iD+lyGuU5CeTQbY25mqohzyZrqWsNjpNgi5t2TyZ7jxjzqt55iAOzuDtQ 6D4xdVSrkEue04pFlIicMbZX5j25Po3NpQG71q34GzZel25zdiwmCJns786SgQ== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 27 Feb 2024 20:22:32 -0300 Message-Id: Cc: <~johnnyrichard/olang-devel@lists.sr.ht> Subject: Re: [PATCH olang] cli: replace memory allocation malloc -> arena From: "Carlos Maniero" To: "Johnny Richard" X-Mailer: aerc 0.15.2-211-g37d5fc691aff References: <20240222191007.78350-1-johnny@johnnyrichard.com> In-Reply-To: X-CM-Analysis: v=2.4 cv=OrhJyT/t c=1 sm=1 tr=0 ts=65de6ebe a=5+VMC1FZ3J4mVPAKpPmAqg==:117 a=5+VMC1FZ3J4mVPAKpPmAqg==:17 a=IkcTkHD0fZMA:10 a=MKtGQD3n3ToA:10 a=1oJP67jkp3AA:10 a=BXDaF_L80NYA:10 a=ttKQAHJnP6EUsgaFGTwA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=QYH75iMubAgA:10 X-CM-Envelope: MS4xfLf/j0odp4EfYhIxB2FMEsS3qE50SQHz8Nl5bEzA8G7Pa1V/ORzyx0atxYvoV7wJx3ve0Hb55iRezX1tne4y+ldpzWSNnm1KNouSgNeAhI6SNI/q9TP1 z43wHFpOHp7SjsCeYGVD1sqFAcYDtiMKrv9iF+t1XvVcLagBhcSi9elMNL4chDZgKkJbDkDFD90XTIW5Rn7IUFgPVVZNFqng5BHsJjuCi8n61ccvqzfxC2hb CCndkuX3gj1nojvJJ3eeoQ== X-AuthUser: carlos@maniero.me X-TUID: xDvINFygWtaP > Do you think the following fixup is good enough? It's perfect! Sorry to hold your patch just for a comment, but since we don't use any tracking tool for TODOs, I think it is a good idea to add TODOs comments on the code to keep tracking on them.