From: "Carlos Maniero" <carlos@maniero.me>
To: "Johnny Richard" <johnny@johnnyrichard.com>,
<ricardo_kagawa@disroot.org>
Cc: <~johnnyrichard/olang-devel@lists.sr.ht>
Subject: Re: [PATCH] fixup! docs: spec: add variables and constants specification
Date: Fri, 12 Apr 2024 23:18:06 -0300 [thread overview]
Message-ID: <D0IMUJHE1C7M.20S3H2NSPM3FU@maniero.me> (raw)
In-Reply-To: <sm7jzr3mklfxscefg25cdhnrtjqldawquvgq6cdczi5kfyt4my@upgwv63nrzw7>
> Thanks a lot for your contribution, I very impressed you managed to send
> a really nice PATCH.
>
> Sorry for that, but there is another Patchset version which was applied
> to the main branch. I think Carlos forgot to mention this Patchset was
> SUPERSEDED[v2] by version 2.
>
> v2: http://lists.johnnyrichard.com/olang/5fzsolce5h42aa6udppiwezgbzeqerkde3xvyilidnkcjaho2j@ygxd7ugzck4m/T/#m0f5cc6f2d49835ec83d4fd5c24d97d2597cb5363
Sorry Ricardo. My bad! I forgot to update the mailing list saying that
this patch was superseded.
> > ---
> > Discussions:
> >
> > - Are you planning to hoist declarations, or are declarations required
> > to be placed before their use?
>
> We are planning to have declarations being placed before their use.
Just an observation here, this is only valid for external declarations
and just inside a function scope.
valid:
1| fn main(): u8 {
2| return exit_success
3| }
4|
4| const exit_success: u8 = 0
invalid:
1| const a = b + 1
2| const b = 0
also invalid:
1| fn main(): u8 {
2| exit_success = 0
3|
4| var exit_success
4| return exit_success
5| }
> Could you please prepare a new patch over the _main_ branch with this
> change (if Carlos agree of course)?
LGTM! And thank you so much for your contributions Ricardo!
next prev parent reply other threads:[~2024-04-13 2:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 3:21 [PATCH olang v1 0/2] docs: variables specification Carlos Maniero
2024-03-27 3:21 ` [PATCH olang v1 1/2] docs: spec: rename program to translation-unit Carlos Maniero
2024-03-27 21:20 ` Johnny Richard
2024-03-28 13:50 ` Carlos Maniero
2024-03-27 3:21 ` [PATCH olang v1 2/2] docs: spec: add variables and constants specification Carlos Maniero
2024-03-27 3:22 ` [olang/patches/.build.yml] build failed builds.sr.ht
2024-03-27 21:37 ` [PATCH olang v1 2/2] docs: spec: add variables and constants specification Johnny Richard
2024-03-28 14:11 ` Carlos Maniero
2024-04-01 17:48 ` Johnny Richard
2024-03-30 1:14 ` Carlos Maniero
2024-04-01 17:54 ` Johnny Richard
2024-04-11 22:39 ` [PATCH] fixup! " ricardo_kagawa
2024-04-12 22:36 ` Johnny Richard
2024-04-13 2:18 ` Carlos Maniero [this message]
2024-04-16 19:01 ` Johnny Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0IMUJHE1C7M.20S3H2NSPM3FU@maniero.me \
--to=carlos@maniero.me \
--cc=johnny@johnnyrichard.com \
--cc=ricardo_kagawa@disroot.org \
--cc=~johnnyrichard/olang-devel@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.johnnyrichard.com/olang.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox