From: "Carlos Maniero" <carlos@maniero.me>
To: <ricardo_kagawa@disroot.org>, <~johnnyrichard/olang-devel@lists.sr.ht>
Subject: Re: [PATCH 0/4] docs: spec: constant initialization and assignments
Date: Tue, 16 Apr 2024 18:58:38 -0300 [thread overview]
Message-ID: <D0LVU1SGWUQU.3KELIDB4KULSL@maniero.me> (raw)
In-Reply-To: <20240416201713.24723-1-ricardo_kagawa@disroot.org>
Thank you so much for your contribution, Ricardo!
Just a few observations:
- In the future patches don't forget to define the
*format.subjectPrefix = PATCH olang*, this is how the olang CI is
triggered. This can be configured once at the repo's *.git/config*.
- We reword your first patch to "docs: spec: make non-terminals more
descriptivedocs: spec: make non-terminals more descriptive" just to
make clear at the short commit message, what the actual change is.
There is a concept we are trying to follow called git recipe history
[1].
Other than that everything is completely amazing! We are glad to
receive your inputs.
Applied!
To git.sr.ht:~johnnyrichard/olang
7cd840e..0046920 main -> main
prev parent reply other threads:[~2024-04-16 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 20:17 ricardo_kagawa
2024-04-16 20:17 ` [PATCH 1/4] docs: spec: refactor grammar specification ricardo_kagawa
2024-04-16 22:32 ` Johnny Richard
2024-04-16 20:17 ` [PATCH 2/4] docs: spec: immediate constant initialization ricardo_kagawa
2024-04-16 22:33 ` Johnny Richard
2024-04-16 20:17 ` [PATCH 3/4] docs: spec: remove assignment as expression ricardo_kagawa
2024-04-16 22:34 ` Johnny Richard
2024-04-16 20:17 ` [PATCH 4/4] docs: spec: postpone assignment operators ricardo_kagawa
2024-04-16 22:35 ` Johnny Richard
2024-04-16 21:58 ` Carlos Maniero [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0LVU1SGWUQU.3KELIDB4KULSL@maniero.me \
--to=carlos@maniero.me \
--cc=ricardo_kagawa@disroot.org \
--cc=~johnnyrichard/olang-devel@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.johnnyrichard.com/olang.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox