public inbox for ~johnnyrichard/olang-devel@lists.sr.ht
 help / color / mirror / code / Atom feed
From: "Carlos Maniero" <carlos@maniero.me>
To: "Johnny Richard" <johnny@johnnyrichard.com>,
	<~johnnyrichard/olang-devel@lists.sr.ht>
Subject: Re: [PATCH olang v1 1/2] tests: build: enhance compiler functional test
Date: Sat, 21 Sep 2024 22:11:30 +0000 (UTC)	[thread overview]
Message-ID: <D4CB1XTK56ZE.361ODAMPWD6H8@maniero.me> (raw)
In-Reply-To: <20240921210512.1100242-2-johnny@johnnyrichard.com>

On Sat Sep 21, 2024 at 6:02 PM -03, Johnny Richard wrote:
> There was two problem with the current state of our integration tests:
>
> 1) The folder structure is very annoying and long to navigate, the last
>    tests folder mess with the shell autocomplete because it has almost
>    the same name as the tests.sh script.

I agree the extra *tests/integration/tests* is really annoying specially
because the auto complete never works once there is a conflict in
between *tests/integration/tests/* and *tests/integration/test.sh*.

Although, I think that *tests/execute* is not very meaningful once the
*execute* word does refer to something in the test domain. You suggested
*tests/compiler* over IRC but I think that it should be clear that it is
a _black box_ testing. Even that I don't like *tests/integration* that
much, I still think it is more meaningful than the suggestions and it
would not be that distracting once we remove the extra *tests* from the
path keeping it from *tests/integration/tests/0001_main_exit.ol* to
*tests/integration/0001_main_exit.ol*.

Otherwise, in case you want reword the tests, it is important to update
our docs[1] as well.

> This change will enable the parallelization and reduce the folder
> structure so we can have a better development experience.

No changes required here, but keep in mind a parallel will mess with the
tests output.

[1]: https://o-lang.org/manual/Building-the-compiler.html#Testing

  reply	other threads:[~2024-09-21 22:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-21 21:02 [PATCH olang v1 0/2] tests: build: improve makefile for tests Johnny Richard
2024-09-21 21:02 ` [PATCH olang v1 1/2] tests: build: enhance compiler functional tests Johnny Richard
2024-09-21 22:11   ` Carlos Maniero [this message]
2024-09-21 21:02 ` [PATCH olang v1 2/2] tests: build: add parallelization support for unit tests Johnny Richard
2024-09-21 21:05   ` [olang/patches/.build.yml] build success builds.sr.ht
2024-09-21 22:30   ` [PATCH olang v1 2/2] tests: build: add parallelization support for unit tests Carlos Maniero
2024-09-22 15:23 ` [PATCH olang v1 0/2] tests: build: improve makefile for tests Johnny Richard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D4CB1XTK56ZE.361ODAMPWD6H8@maniero.me \
    --to=carlos@maniero.me \
    --cc=johnny@johnnyrichard.com \
    --cc=~johnnyrichard/olang-devel@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.johnnyrichard.com/olang.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox