From: Johnny Richard <johnny@johnnyrichard.com>
To: Carlos Maniero <carlos@maniero.me>
Cc: ~johnnyrichard/olang-devel@lists.sr.ht
Subject: Re: [PATCH olang 0/4] comment based integration tests
Date: Fri, 9 Aug 2024 21:42:19 +0200 [thread overview]
Message-ID: <arwyejrp4efankffpuyewl6ia774dmrila3eg5tcgowut3ppzi@dgihzj42yusc> (raw)
In-Reply-To: <20240512143033.229961-1-carlos@maniero.me>
Thanks a lot for this contribution, I think it will improve the
development experience and definitely will help us to move forward
faster.
I have only a small adjustment to suggest, actually a nitpick.
On Sun, May 12, 2024 at 11:30:29AM GMT, Carlos Maniero wrote:
> The old munit based integration tests was replaced by a new mechanism
> that makes testing more tasteful and easy to perform.
>
> To create an integration tests you just need to create a olang file at
> *tests/integration/tests* directory. The assertions are performed
> thought a couple of comments.
The folder *tests/integration/tests* feels a little bit redundant. What
do you think about changing the folder structure to a smaller one like
*test/integration*?
next prev parent reply other threads:[~2024-08-09 18:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 14:30 Carlos Maniero
2024-05-12 14:30 ` [PATCH olang 1/4] tests: add comment based integration tests mechanism Carlos Maniero
2024-05-12 14:30 ` [PATCH olang 2/4] tests: remove previous integration tests structure Carlos Maniero
2024-05-12 14:30 ` [PATCH olang 3/4] tests: include integration tests for function parser errors Carlos Maniero
2024-05-12 14:30 ` [PATCH olang 4/4] tests: print integration tests TODOs Carlos Maniero
2024-05-12 14:31 ` [olang/patches/.build.yml] build success builds.sr.ht
2024-08-09 19:42 ` Johnny Richard [this message]
2024-08-21 15:58 ` [PATCH olang 0/4] comment based integration tests Johnny Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arwyejrp4efankffpuyewl6ia774dmrila3eg5tcgowut3ppzi@dgihzj42yusc \
--to=johnny@johnnyrichard.com \
--cc=carlos@maniero.me \
--cc=~johnnyrichard/olang-devel@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.johnnyrichard.com/olang.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox