From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oNCZMV9ktmZfugAAe85BDQ:P1 (envelope-from ) for ; Fri, 09 Aug 2024 20:48:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id oNCZMV9ktmZfugAAe85BDQ (envelope-from ) for ; Fri, 09 Aug 2024 20:47:59 +0200 X-Envelope-To: patches@johnnyrichard.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=lists.sr.ht header.s=20240113 header.b=hPBpLcQ+; dkim=pass header.d=johnnyrichard.com header.s=key1 header.b="1aWSj6/L"; dmarc=pass (policy=quarantine) header.from=johnnyrichard.com; spf=pass (aspmx1.migadu.com: domain of lists@sr.ht designates 46.23.81.152 as permitted sender) smtp.mailfrom=lists@sr.ht ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=johnnyrichard.com; s=key1; t=1723229279; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=chixLkCfQKd++4y/Zxhd6w2UY5pKJFZffy0914cEAtM=; b=zxvTm6edwdthbMH0nbXqLZmaRVxgJsZRaVzNVEjn26caabDhSlGMdUA54asE2nVkMvLQrt eBMba7EbB0HWL9z6sAaXmJRaQYJ5qQTdbPd8t+Ef/lI5CMEfFUw15DI6Zm7eBl48uZ7JJr su6pHFLPcWaxtCMZL5j//ZiJBTAwGXQqkoWuLG7jdeCfHlhrY4EltpVywfNKRP+oPhSBFx oD0d5YCOCtsjxGySSemfJrmuSkYyclB7OmGrQIXssa08RhibiqXjSxslO5F/FvSOgcXxLG y8tc+UAlra66qxtWrgd8q7diFFQ5U0bW9qfxawuz5UYqqc0jpYpmy5DHrZ+gqQ== ARC-Seal: i=1; s=key1; d=johnnyrichard.com; t=1723229279; a=rsa-sha256; cv=none; b=NZKfwntGlIuSUW1Fz6Z+mkDjEAEcyivXzZgWWI1LAVngVxXfJCdKiw7mY1qUKN+EwFF818 zFftALNClDOWC4rL0+700tnWmKPPZ1wjchsLpWy6jHTKYMAwcx5LIRM7Jy2tjEeQjczfZV woyDjPPkaKDBUU/MDXIO67F9pHinyVeZPJvjwiy5U9Dw5z453ncc3C2gnZf/0lANrAg40L b5BMiCXdFhG6n+fhuIOY+FEiKUfgPcbJL9BM1DlR6HfwyuT8zagS+5ci+Ni8Bqv6RHEDfE LNcWxC7krD0qrtfUdjoMr8eurpufCqpHO37e9MV3l7bYrzoX/N2nhJPtyYlfXA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=lists.sr.ht header.s=20240113 header.b=hPBpLcQ+; dkim=pass header.d=johnnyrichard.com header.s=key1 header.b="1aWSj6/L"; dmarc=pass (policy=quarantine) header.from=johnnyrichard.com; spf=pass (aspmx1.migadu.com: domain of lists@sr.ht designates 46.23.81.152 as permitted sender) smtp.mailfrom=lists@sr.ht Received: from mail-a.sr.ht (mail-a.sr.ht [46.23.81.152]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 23B271334C for ; Fri, 9 Aug 2024 20:47:56 +0200 (CEST) DKIM-Signature: a=rsa-sha256; bh=+16dfj+kblFhZpZ8eFWfmDp11tOT+zbdGnCkQEeacTc=; c=simple/simple; d=lists.sr.ht; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Unsubscribe:List-Subscribe:List-Archive:List-Post:List-ID; q=dns/txt; s=20240113; t=1723229274; v=1; b=hPBpLcQ+ReJMmEBO+HFwy/Gb2lyRxOmHSq4agCnrjfgQ5XqgJFsJR7JGrhrmDluIAWs6z6tC 6G5IutCz+lX0fcqtCzwJtTrm9w+TfN4a6peWjgLFmjsulWQ807T+pzk+Su1/0G3crJ761wK+RvQ HZx+Ew/4XQqNALXa8+Wok9IpoICltTGQZWHwgEZP/3KIwbEJdDO5wTVVMwLX+NUMqmPEK3+VPkK bV0VH0vCNHwvBZjA+At2KIBIXb9Ttc4i5w+oTHYvNaOAH2Ml5P7s4a4Jp8yKQ7ym9mmVnR959Z3 +4GpamTfvIMlvcBurB7eXrG9xQYPLPm25/IHS+hGSEQFQ== Received: from lists.sr.ht (unknown [46.23.81.154]) by mail-a.sr.ht (Postfix) with ESMTPSA id E621220437 for ; Fri, 09 Aug 2024 18:47:54 +0000 (UTC) Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) by mail-a.sr.ht (Postfix) with ESMTPS id 4F6832042D for <~johnnyrichard/olang-devel@lists.sr.ht>; Fri, 09 Aug 2024 18:47:54 +0000 (UTC) Date: Fri, 9 Aug 2024 21:42:19 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=johnnyrichard.com; s=key1; t=1723229273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=chixLkCfQKd++4y/Zxhd6w2UY5pKJFZffy0914cEAtM=; b=1aWSj6/LpqQSCwDOKSbLrnw4sUQNDcyYqCUwy9wCD39bCkcp9AtAwFhZyMB6J186MF9M0Z Ljp/SvdBtfad6EyM8X0rYPFRlNZp9eG8wI2SSYBovqJiaJ2eiXRjg45TkKnCoOyrGrIwsB 3CEsC0wG6Atz89ELPuCqcztyhxLNYzPaSl8M1d87h8epFpf2W0wDbUZ8e3MUHMlPC2pZ1T N2Zc4MnApNkNn3EFMwNWp479nK59JUJyFqi2ih0NMnAUrfelzOzEVw0grXqeElAUoLP1wJ w4M3evMfGKwbFulhgxE6UrbrKeDupPB4YUfwoPW0ExlBYJdDQ43mbX7VQ8JFig== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Johnny Richard To: Carlos Maniero Cc: ~johnnyrichard/olang-devel@lists.sr.ht Subject: Re: [PATCH olang 0/4] comment based integration tests Message-ID: References: <20240512143033.229961-1-carlos@maniero.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240512143033.229961-1-carlos@maniero.me> List-Unsubscribe: List-Subscribe: List-Archive: Archived-At: List-Post: List-ID: ~johnnyrichard/olang-devel <~johnnyrichard/olang-devel.lists.sr.ht> Sender: ~johnnyrichard/olang-devel <~johnnyrichard/olang-devel@lists.sr.ht> X-Migadu-Flow: FLOW_IN X-Migadu-Country: NL X-Migadu-Queue-Id: 23B271334C X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -6.36 X-Spam-Score: -6.36 X-TUID: /E6Q6qmwKCtS Thanks a lot for this contribution, I think it will improve the development experience and definitely will help us to move forward faster. I have only a small adjustment to suggest, actually a nitpick. On Sun, May 12, 2024 at 11:30:29AM GMT, Carlos Maniero wrote: > The old munit based integration tests was replaced by a new mechanism > that makes testing more tasteful and easy to perform. > > To create an integration tests you just need to create a olang file at > *tests/integration/tests* directory. The assertions are performed > thought a couple of comments. The folder *tests/integration/tests* feels a little bit redundant. What do you think about changing the folder structure to a smaller one like *test/integration*?