Re: [PATCH olang 2/3] tests: decouple command execution from cli_runner

[Johnny Richard <johnny@johnnyrichard.com>]

On Thu, Mar 07, 2024 at 08:23:21PM -0300, Carlos Maniero wrote:
> -        execv(OLANG_COMPILER_PATH, args);
> -        perror("execl error.");
> -        exit(127);
> -    } else {
> -        close(fd_link[1]);
> -        if (read(fd_link[0], result.compiler_output, sizeof(result.compiler_output)) == -1) {

We are not reading the full ouptut here.  We can implement a logic to
read the whole string or leave a TODO comment here.

> diff --git a/tests/integration/cli_runner.h b/tests/integration/cli_runner.h
> index 7ce4e7b..785cd34 100644
> --- a/tests/integration/cli_runner.h
> +++ b/tests/integration/cli_runner.h
> @@ -16,13 +16,17 @@
>   */
>  #ifndef CLI_RUNNER_H
>  #define CLI_RUNNER_H
> +#include "proc_exec.h"
> +
>  typedef struct cli_result_t
>  {
> -    int exit_code;
> -    char program_path[255];
> -    char compiler_output[1024];

Perhaps leave a TODO comment here about making it not sized? 
> +void
> +proc_exec(proc_exec_command_t* command)
> +{
> +    int fd_link[2];

nitpick: fd_link might miss leading to wrong understating.  What do you
think about changing it to fd_pipe to be clearer?