Re: [PATCH olang v1 3/3] cli: add compilation -o option with --save-temps

[Johnny Richard <johnny@johnnyrichard.com>]

On Mon, Mar 04, 2024 at 11:02:14PM -0300, Carlos Maniero wrote:
> 
> > +typedef enum
> > +{
> > +    CLI_OPT_DUMP_TOKENS = 1 << 1,
> > +    CLI_OPT_OUTPUT = 1 << 2,
> > +    CLI_OPT_SAVE_TEMPS = 1 << 3
> > +} cli_opt;
> 
> nitpick: Any particular reason to avoid using the first bit?

no reason, I will fix it!

> What is the point of making *file_path* a SV? Ever single place it is
> used you are accessing it's char pointer directly - *file_path.chars*.
> It looks unsafe to just ignore the SV's size, example:
> *print_token(opts->file_path.chars, &token)*

I made file_path a string view to keep alined with other string view
fields.  It was just cosmetic.  I agree on keep a cstr instead.

> > -    char *prog = cli_args_shift(&args);
> > +    opts.prog = string_view_from_cstr(cli_args_shift(&args));
> 
> nitpick: Is that a standard calling arg0 as prog? I know it was already
> there, but taking a fresh look at this name, I find it hard to
> understand. WDYT about *opts.compiler_path*, *opts.the_0c_path* or
> *opts.this_path*? The point is that, program can be ambiguos here as it
> could be both the compiler's program or the program to be compiled.

I will go with **compiler_path** for this one.

> > +    assert(opts && "args is required");
> 
> s/opts/args

Opss...

> > +    string_view_t asm_ext = string_view_from_cstr(".s");
> > +    char asm_file[opts->output_bin.size + asm_ext.size + 1];
> > +    memcpy(asm_file, opts->output_bin.chars, opts->output_bin.size);
> > +    memcpy(asm_file + opts->output_bin.size, asm_ext.chars, asm_ext.size);
> > +    asm_file[opts->output_bin.size + asm_ext.size] = 0;
> 
> nitpick: you have achieved the same later at this same file using
> *sprintf* which I think reads better.
> 
> +    char asm_file[opts->output_bin.size + 3];
> +    sprintf(asm_file, "" SV_FMT ".s", SV_ARG(opts->output_bin));

Sure...