Re: [PATCH olang 3/5] codegen: fix map simbol list type

[Johnny Richard <johnny@johnnyrichard.com>]

There is a typo on the patch subject.

> Subject: Re: [PATCH olang 3/5] codegen: fix map simbol list type

s/simbol/symbol/

On Sat, Sep 21, 2024 at 08:24:58AM GMT, Carlos Maniero wrote:
> It was supposed to be an array of pointers.
> 
> Signed-off-by: Carlos Maniero <carlos@maniero.me>
> ---
>  src/codegen_linux_x86_64.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/codegen_linux_x86_64.c b/src/codegen_linux_x86_64.c
> index 3ce11a7..1fa6c58 100644
> --- a/src/codegen_linux_x86_64.c
> +++ b/src/codegen_linux_x86_64.c
> @@ -426,9 +426,9 @@ calculate_fn_local_size(scope_t *scope)
>  
>      size_t local_size = 0;
>  
> -    map_kv_t kvs[scope->symbols->size];
> +    map_kv_t *kvs[scope->symbols->size];
>  
> -    map_get_kvs(scope->symbols, (map_kv_t **)kvs);
> +    map_get_kvs(scope->symbols, kvs);

Great catch!

>  
>      for (size_t i = 0; i < scope->symbols->size; ++i) {
>          // FIXME: symbols must have their types. Since we just have 8bytes
> -- 
> 2.34.1
>