From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cOvhIUgV72Z44QAA62LTzQ:P1 (envelope-from ) for ; Sat, 21 Sep 2024 20:49:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id cOvhIUgV72Z44QAA62LTzQ (envelope-from ) for ; Sat, 21 Sep 2024 20:49:44 +0200 X-Envelope-To: patches@johnnyrichard.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=lists.sr.ht header.s=20240113 header.b=E0qp7dt9; dkim=pass header.d=johnnyrichard.com header.s=key1 header.b=w7FR01K+; spf=pass (aspmx1.migadu.com: domain of lists@sr.ht designates 46.23.81.152 as permitted sender) smtp.mailfrom=lists@sr.ht; dmarc=pass (policy=quarantine) header.from=johnnyrichard.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=johnnyrichard.com; s=key1; t=1726944584; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=jyk9Ayhs/7jXXAXwCLmc24FveL6cUqnbqixb/7atGfg=; b=H+9spQZykqX9HoFCO8bsVn7vQuCL73Aqv+mz3V+QRljRH2aac6sCzWA9tBCW7Euw13qYdY 3VR9hw1cPhxUksLiHYsUXHopN8Zi8Ne9PBid0THQD+SLit7uH4+j9HtUTJVrShyYDIG0vD vgqpjBKwV/IU0ylQEFNDnyTNsVjw0WYQrnUv21kAWQPAlw7nr+DvMKZvSFW50L5FuZ0Ja/ i1vg/FGFJ4+KAcMe9S0cXC7+DS2T7P1JDlHckR8VY8knMC8fV6xzbDOcIAaVTZ21UgG+WS LX4ppGOG3865s3FPPqUyti+Jjk2kPy+6hLm16qpDc+6G6XTpqMcMjU3dkXr+zg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=lists.sr.ht header.s=20240113 header.b=E0qp7dt9; dkim=pass header.d=johnnyrichard.com header.s=key1 header.b=w7FR01K+; spf=pass (aspmx1.migadu.com: domain of lists@sr.ht designates 46.23.81.152 as permitted sender) smtp.mailfrom=lists@sr.ht; dmarc=pass (policy=quarantine) header.from=johnnyrichard.com ARC-Seal: i=1; s=key1; d=johnnyrichard.com; t=1726944584; a=rsa-sha256; cv=none; b=iS58uTdFKC8KlrEIokZMzlpbSYQcHG4/qbuI99dBGpBnN0krjfELfhG1jGwHpjUT+YQqPp yPdY4pxQ1emt/+qEDDGle3fnMrBYjEhLzvkZ9kUFrXclo9ysft6q20ULP/f/A4w3FCUxrl 35rXqEmVtqG3AgAY5I3rCZXpzqrEInx86mzj0cDDWERiWZdcuqTMsjjLME4k4Da5exlmK1 g1IsONZ+S9z4xfXwXT7mffWKLLFcJ9pkvuk+TDp2EXE5OLyZ6tRDMalhx1AasoavvwZHEk 0Y8Ec1GHU60ieBBolNUbqAsho7lVLzhPDzhIsBhRD+ufWURr5rWmQG6LNyXgaA== Received: from mail-a.sr.ht (mail-a.sr.ht [46.23.81.152]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4569176BA0 for ; Sat, 21 Sep 2024 20:49:44 +0200 (CEST) DKIM-Signature: a=rsa-sha256; bh=BH6p9dPEmK+zDlV1eI5J5G3B76ZO+ocSFTbeP3bJs9w=; c=simple/simple; d=lists.sr.ht; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Unsubscribe:List-Subscribe:List-Archive:List-Post:List-ID; q=dns/txt; s=20240113; t=1726944583; v=1; b=E0qp7dt9KDT0qypSsZjoD0bBDfJGHzntdEecncN8+3FvvmU88kkcCqEw6zrgFlIfD+ZrcF16 cWBVd3IncvFQPyveTv1MrpQE1vAXb9lFN9x+CNUiDQy7coX9oecBwN5gBiRQAhxNyrO9fxAxYCE 5YIhib/Pt9Q71Wni1xHobTKdym5dCwmjq5NKCuL/0SsCVXKru1sTCPLYnOunDYuT7yYXPHEg3bd 4b5JK6dS3G3gai+H1l9z9SXEaQxkw4CAjgjWesopZQn2ukJJV5Tn6u9KVxNoY+QMnGg8deqqNM8 vN7s6nyPVRgKloAx80TxYTKlDqt/wMr7Pa9a01vXGxkqA== Received: from lists.sr.ht (unknown [46.23.81.154]) by mail-a.sr.ht (Postfix) with ESMTPSA id E630B2032E for ; Sat, 21 Sep 2024 18:49:43 +0000 (UTC) Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by mail-a.sr.ht (Postfix) with ESMTPS id 5787620320 for <~johnnyrichard/olang-devel@lists.sr.ht>; Sat, 21 Sep 2024 18:49:43 +0000 (UTC) Date: Sat, 21 Sep 2024 20:50:00 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=johnnyrichard.com; s=key1; t=1726944582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jyk9Ayhs/7jXXAXwCLmc24FveL6cUqnbqixb/7atGfg=; b=w7FR01K+70QgZ4zVpU47dxklSLeBqP/06mYl3mc0JrCpr7dOs8sRx4D7pImy9sGvfjnXmF mhn1nfIuw838B/9X1GOfb4iWO40N/CrJUxWR1szTyP74czeG2qlJpedx97BruEA+4wW8fr c1Kq1/WHnHZ4TFTt7539RGaOlrXj028pGD3+WG7jJVh2TYsV3gYNIMJQKm/Wwi/B9YWRKb xSLm/xri8CUvYL9G8u0KH4Mso2HAUeiFGpsc/q3NcWLMsQoeyI9ZcGWQYqQUK91HOfO6uP uqQ9FBd7abRJZgZhbI2X7gMkYeEsYrgJPx+VfTHrEFQBqJUKyzyxI2N85NtrCQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Johnny Richard To: Carlos Maniero Cc: ~johnnyrichard/olang-devel@lists.sr.ht Subject: Re: [PATCH olang 3/5] codegen: fix map simbol list type Message-ID: References: <20240921082437.396691-1-carlos@maniero.me> <20240921082437.396691-4-carlos@maniero.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240921082437.396691-4-carlos@maniero.me> List-Unsubscribe: List-Subscribe: List-Archive: Archived-At: List-Post: List-ID: ~johnnyrichard/olang-devel <~johnnyrichard/olang-devel.lists.sr.ht> Sender: ~johnnyrichard/olang-devel <~johnnyrichard/olang-devel@lists.sr.ht> X-Migadu-Flow: FLOW_IN X-Migadu-Country: NL X-Migadu-Queue-Id: 4569176BA0 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -6.90 X-Migadu-Spam-Score: -6.90 X-TUID: V2MisYjRYO2m There is a typo on the patch subject. > Subject: Re: [PATCH olang 3/5] codegen: fix map simbol list type s/simbol/symbol/ On Sat, Sep 21, 2024 at 08:24:58AM GMT, Carlos Maniero wrote: > It was supposed to be an array of pointers. > > Signed-off-by: Carlos Maniero > --- > src/codegen_linux_x86_64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/codegen_linux_x86_64.c b/src/codegen_linux_x86_64.c > index 3ce11a7..1fa6c58 100644 > --- a/src/codegen_linux_x86_64.c > +++ b/src/codegen_linux_x86_64.c > @@ -426,9 +426,9 @@ calculate_fn_local_size(scope_t *scope) > > size_t local_size = 0; > > - map_kv_t kvs[scope->symbols->size]; > + map_kv_t *kvs[scope->symbols->size]; > > - map_get_kvs(scope->symbols, (map_kv_t **)kvs); > + map_get_kvs(scope->symbols, kvs); Great catch! > > for (size_t i = 0; i < scope->symbols->size; ++i) { > // FIXME: symbols must have their types. Since we just have 8bytes > -- > 2.34.1 >