[PATCH olang v2] spec: remove comments from the spec

[PATCH olang v2] spec: remove comments from the spec

[Carlos Maniero]

The comments bellow were now allowed following our spec:

{
  # this is now allowed
  return 1 # so is this
}

To avoid spreading the comment all over our spec, the comment is no
longer part of the spec and we are get riding of anything that starts
with #.

Signed-off-by: Carlos Maniero <carlos@maniero.me>
---
 contrib/bin/run-ebnf | 2 +-
 docs/info/olang.ebnf | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/contrib/bin/run-ebnf b/contrib/bin/run-ebnf
index 4b2b559..85b7c35 100755
--- a/contrib/bin/run-ebnf
+++ b/contrib/bin/run-ebnf
@@ -19,4 +19,4 @@ BASEDIR="$(dirname "$0")"
 
 DEPS='{:deps {instaparse/instaparse {:mvn/version "1.5.0"}}}'
 
-cat $BASEDIR/../../docs/info/olang.ebnf | sed 's/<\([a-z-]*\)>/\1/g' | FILE="$1" clj -Sdeps "$DEPS" -M $BASEDIR/ebnf.clj
+cat $BASEDIR/../../docs/info/olang.ebnf | sed 's/<\([a-z-]*\)>/\1/g' | FILE=<(cat $1 | sed 's/#.*$//') clj -Sdeps "$DEPS" -M $BASEDIR/ebnf.clj
diff --git a/docs/info/olang.ebnf b/docs/info/olang.ebnf
index 791c6f0..0bc7eb5 100644
--- a/docs/info/olang.ebnf
+++ b/docs/info/olang.ebnf
@@ -1,5 +1,5 @@
 (* Entry Point *)
-<translation-unit> ::= (<ows> (<external-declaration> | <comment>) <ows> (<end-of-statement> | <end-of-file>))*
+<translation-unit> ::= (<ows> (<external-declaration>) <ows> (<end-of-statement> | <end-of-file>))*
 
 (* Translation Unit *)
 <external-declaration> ::= <common-statement> | <function-definition>
@@ -76,7 +76,6 @@
 <integer-base16>  ::= #'0[Xx]' <hex-digit> (<hex-digit> | '_')*
 
 (* Utilities *)
-<comment>      ::= '#' #'[^\n]*'
 <ws>           ::= <white-space>+
 <ows>          ::= <white-space>*
 <white-space>  ::= <linear-space> | <line-break>
-- 
2.46.1

[olang/patches/.build.yml] build success

[builds.sr.ht]

olang/patches/.build.yml: SUCCESS in 34s

[spec: remove comments from the spec][0] v2 from [Carlos Maniero][1]

[0]: https://lists.sr.ht/~johnnyrichard/olang-devel/patches/55508
[1]: mailto:carlos@maniero.me

✓ #1352064 SUCCESS olang/patches/.build.yml https://builds.sr.ht/~johnnyrichard/job/1352064

Re: [PATCH olang v2] spec: remove comments from the spec

[Johnny Richard]

On Wed, Oct 16, 2024 at 07:41:04PM GMT, Carlos Maniero wrote:
> The comments bellow were now allowed following our spec:
> 
> {
>   # this is now allowed
>   return 1 # so is this
> }
> 
> To avoid spreading the comment all over our spec, the comment is no
> longer part of the spec and we are get riding of anything that starts
> with #.

s/get riding/getting rid/

Thanks, I just added a few fix on the patch log. Applied!

To git.sr.ht:~johnnyrichard/olang
   cf5e4ab..33c5e25  main -> main