Re: [PATCH olang] cli: replace memory allocation malloc -> arena

[Johnny Richard <johnny@johnnyrichard.com>]

On Tue, Feb 27, 2024 at 12:44:47PM -0300, Carlos Maniero wrote:
> > diff --git a/src/0c.c b/src/0c.c
> > index 978b770..f0ac974 100644
> > --- a/src/0c.c
> > +++ b/src/0c.c
> 0c.c no longer exists
> 
> > +#define ARENA_CAPACITY (1024 * 1024)
> Can you add a TODO comment to us to remember to solve this issue in the
> feature? We can both make a algorithm to predict how much memory we
> gonna need or make arena expandable.

Do you think the following fixup is good enough?

------->8-------
Subject: [PATCH olang] fixup! cli: replace memory allocation malloc -> arena


diff --git a/src/main.c b/src/main.c
index f0ac974..2b2f12a 100644
--- a/src/main.c
+++ b/src/main.c
@@ -25,6 +25,7 @@
 #include "lexer.h"
 #include "string_view.h"
 
+// TODO: find a better solution to define the arena capacity
 #define ARENA_CAPACITY (1024 * 1024)
 
 typedef struct cli_args