* [olang/patches/.build.yml] build failed
2024-03-02 19:02 [PATCH olang] string_view: add n + 1 test to string_view_to_u32 function Johnny Richard
@ 2024-03-02 18:03 ` builds.sr.ht
2024-03-02 19:53 ` [PATCH olang] string_view: add n + 1 test to string_view_to_u32 function Johnny Richard
1 sibling, 0 replies; 3+ messages in thread
From: builds.sr.ht @ 2024-03-02 18:03 UTC (permalink / raw)
To: Johnny Richard; +Cc: ~johnnyrichard/olang-devel
olang/patches/.build.yml: FAILED in 40s
[string_view: add n + 1 test to string_view_to_u32 function][0] from [Johnny Richard][1]
[0]: https://lists.sr.ht/~johnnyrichard/olang-devel/patches/49946
[1]: mailto:johnny@johnnyrichard.com
✗ #1160663 FAILED olang/patches/.build.yml https://builds.sr.ht/~johnnyrichard/job/1160663
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH olang] string_view: add n + 1 test to string_view_to_u32 function
@ 2024-03-02 19:02 Johnny Richard
2024-03-02 18:03 ` [olang/patches/.build.yml] build failed builds.sr.ht
2024-03-02 19:53 ` [PATCH olang] string_view: add n + 1 test to string_view_to_u32 function Johnny Richard
0 siblings, 2 replies; 3+ messages in thread
From: Johnny Richard @ 2024-03-02 19:02 UTC (permalink / raw)
To: ~johnnyrichard/olang-devel; +Cc: Johnny Richard
Signed-off-by: Johnny Richard <johnny@johnnyrichard.com>
---
tests/unit/string_view_test.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/unit/string_view_test.c b/tests/unit/string_view_test.c
index 1d8627f..fe3dacb 100644
--- a/tests/unit/string_view_test.c
+++ b/tests/unit/string_view_test.c
@@ -48,6 +48,10 @@ string_view_to_u32_test(const MunitParameter params[], void *user_data_or_fixtur
assert_uint32(string_view_to_u32(str), ==, 69);
+ str = (string_view_t) { .chars = "39;", .size = 2 };
+
+ assert_uint32(string_view_to_u32(str), ==, 39);
+
return MUNIT_OK;
}
--
2.44.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH olang] string_view: add n + 1 test to string_view_to_u32 function
2024-03-02 19:02 [PATCH olang] string_view: add n + 1 test to string_view_to_u32 function Johnny Richard
2024-03-02 18:03 ` [olang/patches/.build.yml] build failed builds.sr.ht
@ 2024-03-02 19:53 ` Johnny Richard
1 sibling, 0 replies; 3+ messages in thread
From: Johnny Richard @ 2024-03-02 19:53 UTC (permalink / raw)
To: ~johnnyrichard/olang-devel
This patch has few problems:
- Do not add a better tests convarge.
- Has lint issues
I'm rejecting it. No review needed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-02 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-02 19:02 [PATCH olang] string_view: add n + 1 test to string_view_to_u32 function Johnny Richard
2024-03-02 18:03 ` [olang/patches/.build.yml] build failed builds.sr.ht
2024-03-02 19:53 ` [PATCH olang] string_view: add n + 1 test to string_view_to_u32 function Johnny Richard
Code repositories for project(s) associated with this public inbox
https://git.johnnyrichard.com/olang.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox