From: Johnny Richard <johnny@johnnyrichard.com>
To: Carlos Maniero <carlos@maniero.me>
Cc: ~johnnyrichard/olang-devel@lists.sr.ht
Subject: Re: [PATCH olang] olang project bootstrap
Date: Tue, 13 Feb 2024 21:52:30 +0100 [thread overview]
Message-ID: <qfz6uez6q2kbv3qe6ocqtl7gb4ppxvxdbzmrut65mdvisid6sb@zy6zvtz7wqsm> (raw)
In-Reply-To: <20240213192034.4712-1-carlos@maniero.me>
I have applied few minor fixes to the patch:
1) The Makefile was point to test folder which doesn't exists at this
moment.
2) The clang-format is not happy with the src/0c.c file, I applied the
linter-fix to adjust the style.
The following fixup patch listed below:
Johnny Richard
---->8----
Subject: Fixup
diff --git a/Makefile b/Makefile
index e93b2ce..2a23b59 100644
--- a/Makefile
+++ b/Makefile
@@ -19,12 +19,10 @@ $(BUILD_DIR):
.PHONY: linter
linter: $(SRCS) $(HEADERS)
clang-format --dry-run --Werror $?
- $(MAKE) -C test linter
.PHONY: linter-fix
linter-fix: $(SRCS) $(HEADERS)
clang-format -i $?
- $(MAKE) -C test linter-fix
$(BUILD_DIR)/%.o: $(SRC_DIR)/%.c
$(CC) $(CFLAGS) -c $< -o $@
diff --git a/src/0c.c b/src/0c.c
index d66ef12..97a8f47 100644
--- a/src/0c.c
+++ b/src/0c.c
@@ -14,6 +14,8 @@
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <https://www.gnu.org/licenses/>.
*/
-int main() {
- return 0;
+int
+main(void)
+{
+ return 0;
}
prev parent reply other threads:[~2024-02-13 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 19:20 Carlos Maniero
2024-02-13 20:52 ` Johnny Richard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qfz6uez6q2kbv3qe6ocqtl7gb4ppxvxdbzmrut65mdvisid6sb@zy6zvtz7wqsm \
--to=johnny@johnnyrichard.com \
--cc=carlos@maniero.me \
--cc=~johnnyrichard/olang-devel@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.johnnyrichard.com/olang.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox