From: Johnny Richard <johnny@johnnyrichard.com>
To: Carlos Maniero <carlos@maniero.me>
Cc: ~johnnyrichard/olang-devel@lists.sr.ht
Subject: Re: [PATCH olang v2] arena: optimization: make arena 8 bits aligned
Date: Thu, 22 Feb 2024 19:50:21 +0100 [thread overview]
Message-ID: <rt4fct637knxn7vte5lmdovgurx6ysm2qv2ol5in3v5s7zsaro@lffcfwncxljy> (raw)
In-Reply-To: <20240221150911.3670778-1-carlos@maniero.me>
On Wed, Feb 21, 2024 at 12:09:11PM -0300, Carlos Maniero wrote:
> Subject: [PATCH olang v2] arena: optimization: make arena 8 bits aligned
The patch title is say you are using 8 bits but the implementation is
platform agnostic.
Perhaps we could change it to:
arena: ensure aligned memory access
> This commit changes the pointers returned by *arena_alloc* to always be
> system-word aligned.
>
> Non-aligned data structure could have a huge impact on performance. Take
> the example bellow:
We could also link to a document[1] that explains better the problem like
the kernel one.
[1]: https://www.kernel.org/doc/html/next/_sources/core-api/unaligned-memory-access.rst.txt
> v2:
> - There was I bug on the padding logic. I fixed it and tests were
> added.
Could you please reply to the first patch which bug you have
encountered?
next prev parent reply other threads:[~2024-02-22 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 15:09 Carlos Maniero
2024-02-21 15:09 ` [olang/patches/.build.yml] build success builds.sr.ht
2024-02-22 18:50 ` Johnny Richard [this message]
2024-02-28 14:04 ` [PATCH olang v2] arena: optimization: make arena 8 bits aligned Carlos Maniero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rt4fct637knxn7vte5lmdovgurx6ysm2qv2ol5in3v5s7zsaro@lffcfwncxljy \
--to=johnny@johnnyrichard.com \
--cc=carlos@maniero.me \
--cc=~johnnyrichard/olang-devel@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.johnnyrichard.com/olang.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox