From: Johnny Richard <johnny@johnnyrichard.com>
To: Carlos Maniero <carlos@maniero.me>
Cc: ~johnnyrichard/olang-devel@lists.sr.ht
Subject: Re: [PATCH olang v1 1/3] ast: return_stmt rename expr field and add it to the factory fn
Date: Mon, 23 Sep 2024 13:02:10 +0200 [thread overview]
Message-ID: <twnfflzmy4ift5v7xd5opkazhq6abjqq47hhsxkdghfhvcuoik@5mtn5cqrfekz> (raw)
In-Reply-To: <20240923101141.76783-2-carlos@maniero.me>
On Mon, Sep 23, 2024 at 10:11:52AM GMT, Carlos Maniero wrote:
> The *ast_new_node_return_stmt* was not receiving the expr as argument,
> it was changed to keep it consistent, once we always expect the
> factory functions to return a valid ast_node.
This is okay for now, but probably we might need return without
expression (void functions) in the future.
next prev parent reply other threads:[~2024-09-23 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 10:11 [PATCH olang v1 0/3] Housekeeping: resolve a few FIXMEs related to code style Carlos Maniero
2024-09-23 10:11 ` [PATCH olang v1 1/3] ast: return_stmt rename expr field and add it to the factory fn Carlos Maniero
2024-09-23 11:02 ` Johnny Richard [this message]
2024-09-23 11:47 ` Carlos Maniero
2024-09-23 10:11 ` [PATCH olang v1 2/3] codegen: move label_index global variable to the codegen scope Carlos Maniero
2024-09-23 10:11 ` [PATCH olang v1 3/3] naming: rename all identifier symbols to id Carlos Maniero
2024-09-23 10:12 ` [olang/patches/.build.yml] build success builds.sr.ht
2024-09-23 11:08 ` [PATCH olang v1 0/3] Housekeeping: resolve a few FIXMEs related to code style Johnny Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=twnfflzmy4ift5v7xd5opkazhq6abjqq47hhsxkdghfhvcuoik@5mtn5cqrfekz \
--to=johnny@johnnyrichard.com \
--cc=carlos@maniero.me \
--cc=~johnnyrichard/olang-devel@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.johnnyrichard.com/olang.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox