From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4Bi6LshK8WY0rgAAe85BDQ:P1 (envelope-from ) for ; Mon, 23 Sep 2024 13:02:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 4Bi6LshK8WY0rgAAe85BDQ (envelope-from ) for ; Mon, 23 Sep 2024 13:02:32 +0200 X-Envelope-To: patches@johnnyrichard.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=lists.sr.ht header.s=20240113 header.b=qCMop0LY; dkim=pass header.d=johnnyrichard.com header.s=key1 header.b=lxl4ARme; spf=pass (aspmx1.migadu.com: domain of lists@sr.ht designates 46.23.81.152 as permitted sender) smtp.mailfrom=lists@sr.ht; dmarc=pass (policy=quarantine) header.from=johnnyrichard.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=johnnyrichard.com; s=key1; t=1727089352; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=wtx/nAO8rsdn8NX3Iy8tW2BhlB7r+YmZY91acgtmT2U=; b=W8DgRE2p5g2DHrfojWZhVsY3qkRMsY7S2zdRrdAiwUsLsY4HiGUUdl8Lb4+6hWMwIKZwAo ie+y9644PNbvkvb/0vp9zmuwI+5S+HQiOmUYgdiKlLwVrAZcao0UKveEOhPEmzwajdZQZP ixTiKgfgxSVeEPv+6FzHTqF662iv5OToFvMjKvh2c6oeJZ5+JEVGhJpH9dY8T0awGteHVr sKayCN9x106ntDPHpnZSUE6oWnouglND8Vfru3I1HqSj7QGUciqd69ZeKcB4FTILEd+sqF hcEM9YVW9xwiKULQ254uYIHQHADOTq2xp2MKxjFSoH5WZDrtznKfAyraunZwEw== ARC-Seal: i=1; s=key1; d=johnnyrichard.com; t=1727089352; a=rsa-sha256; cv=none; b=pUkg33HeVYI2WSqVOdKkH0peO9qgNdPBGFxdUxlfQZAORJYOUu+ghySHW82hvM0agQftVP K3CXt0hjs6Gr59x9gxSzWZIydEyxSo2UH6cfVHjUXR19V/JELMBhwl5H5qXAbXkkxunSSK sKpvhot4S3apsn+va7CHvzIOmJNah3boxPVrE9VF4B7MvZBtqfhEjTC5KUqVk4JpKywitY AQt4jfuL7LB/SmH78HHVOSCBoxHYkbh64MlhrwYHeRuepLBVPf2FaSaiqJ/pgCOLy5byh+ IQvW/G9AVq0vLX2geg/jxSOOByjvCAHKCE+dnOYJLFKCt2GMLSqhWtPM4wno+g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=lists.sr.ht header.s=20240113 header.b=qCMop0LY; dkim=pass header.d=johnnyrichard.com header.s=key1 header.b=lxl4ARme; spf=pass (aspmx1.migadu.com: domain of lists@sr.ht designates 46.23.81.152 as permitted sender) smtp.mailfrom=lists@sr.ht; dmarc=pass (policy=quarantine) header.from=johnnyrichard.com Received: from mail-a.sr.ht (mail-a.sr.ht [46.23.81.152]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9FB347C951 for ; Mon, 23 Sep 2024 13:02:32 +0200 (CEST) DKIM-Signature: a=rsa-sha256; bh=wtx/nAO8rsdn8NX3Iy8tW2BhlB7r+YmZY91acgtmT2U=; c=simple/simple; d=lists.sr.ht; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Unsubscribe:List-Subscribe:List-Archive:List-Post:List-ID; q=dns/txt; s=20240113; t=1727089352; v=1; b=qCMop0LY/E9R1wwBHcVu8pP4btBsAdn5oz8+THo/eqtyES9V6uaon01Hn00dn3euiwzzdA/w 7LM3SdmuMgBkeJ5UrNbQO5JFAa60RBEnXdv/oQaTaZtUaHmFMaG9W5CwyeGjWiRizxjBk/+7QDl 02r2svzZLra9u1CM5XddJ+9qV7Q/LlI34Lk+M/Vq86ea093GIfNUR60VIdm0T2I1Dh5aj4CodAQ LRdztqpa45Yxj+ok2ZAL8lDWpUQNDb1esrINMiUuczr3CIqW1v0Jm+BF/lBIztmDn1shBLK5HFb BR9w/xF1HetbXH7HFYtb7a5PdMx44blT8EA2zZTwJvm8g== Received: from lists.sr.ht (unknown [46.23.81.154]) by mail-a.sr.ht (Postfix) with ESMTPSA id 7F9C920213 for ; Mon, 23 Sep 2024 11:02:32 +0000 (UTC) Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by mail-a.sr.ht (Postfix) with ESMTPS id DA0F320200 for <~johnnyrichard/olang-devel@lists.sr.ht>; Mon, 23 Sep 2024 11:02:31 +0000 (UTC) Date: Mon, 23 Sep 2024 13:02:10 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=johnnyrichard.com; s=key1; t=1727089351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wtx/nAO8rsdn8NX3Iy8tW2BhlB7r+YmZY91acgtmT2U=; b=lxl4ARmeHQ7ViGgBQ4yDy2APhSAGgZnYoVen1Xpmi7J3uCEkz/ZzvmaHWKYMFld+Ml+77O 9KTpY9WDCX+gDDd7JDpke3S+n9CzxCED6PuqY3E/SC9diw22DnnO+zA8tNwDTMgrKYD7Z1 I4uUFTLNAKgfYmJ74eMKm1WnFQJRU0XT1QDGp5INJ11nn9vD+JdzYksX0792ziNii1CmxD +4FGzn/dV8DZVr1g9pEPsP+bCRRX7jxK5gAcGIw2hLgLcVXLUuSHXwzNgcq0SI2meHBtZU 5ejyVsP5AuK8CuPd7gPC/P4kk9xYsy/l3AgjA3xgRGfm+ANcglCyRtrEeMkMzQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Johnny Richard To: Carlos Maniero Cc: ~johnnyrichard/olang-devel@lists.sr.ht Subject: Re: [PATCH olang v1 1/3] ast: return_stmt rename expr field and add it to the factory fn Message-ID: References: <20240923101141.76783-1-carlos@maniero.me> <20240923101141.76783-2-carlos@maniero.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240923101141.76783-2-carlos@maniero.me> List-Unsubscribe: List-Subscribe: List-Archive: Archived-At: List-Post: List-ID: ~johnnyrichard/olang-devel <~johnnyrichard/olang-devel.lists.sr.ht> Sender: ~johnnyrichard/olang-devel <~johnnyrichard/olang-devel@lists.sr.ht> X-Migadu-Flow: FLOW_IN X-Migadu-Country: NL X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -6.80 X-Migadu-Queue-Id: 9FB347C951 X-Spam-Score: -6.80 X-TUID: VWIei2987MDy On Mon, Sep 23, 2024 at 10:11:52AM GMT, Carlos Maniero wrote: > The *ast_new_node_return_stmt* was not receiving the expr as argument, > it was changed to keep it consistent, once we always expect the > factory functions to return a valid ast_node. This is okay for now, but probably we might need return without expression (void functions) in the future.